Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout progress dashboard: allow using cortex_request_duration_seconds native histogram #8779

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

duricanikolic
Copy link
Contributor

What this PR does

Allow using cortex_request_duration_seconds native histogram in
overview dashboard everywhere.

Which issue(s) this PR fixes or relates to

Related to #7154
Depends on grafana/jsonnet-libs#1285

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@duricanikolic duricanikolic self-assigned this Jul 21, 2024
@duricanikolic duricanikolic force-pushed the yuri/native-hist-rollout-progress-dashboard branch from 2dabc48 to 75e684b Compare July 21, 2024 17:14
@duricanikolic duricanikolic marked this pull request as ready for review July 21, 2024 22:38
@duricanikolic duricanikolic requested a review from a team as a code owner July 21, 2024 22:38
@duricanikolic duricanikolic requested a review from krajorama July 21, 2024 22:38
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed on chat, there are nice-to-fix issues with the dashboard , but not related to native histograms.

@duricanikolic duricanikolic merged commit e8e4dc7 into main Jul 22, 2024
31 checks passed
@duricanikolic duricanikolic deleted the yuri/native-hist-rollout-progress-dashboard branch July 22, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants