Configure split-and-merge compactor in jsonnet #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Jan 24, 2022
| @@ -19,6 +19,18 @@ | |||
| 'compactor.compaction-concurrency': $._config.cortex_compactor_max_concurrency, | |||
| 'compactor.cleanup-interval': $._config.cortex_compactor_cleanup_interval, | |||
|
|
|||
| // Will be set on per-tenant basis via overrides and user classes. No splitting by default. | |||
| 'compactor.split-and-merge-shards': 0, | |||
| 'compactor.compactor-tenant-shard-size': 1, | |||
There was a problem hiding this comment.
Our new default in #852 is 0. Shall we use the same value?
There was a problem hiding this comment.
My take on this: config defaults should target generic users not necessarily using our jsonnet. Our jsonnet reflects our setup (eg. we have user classes and override it on large tenants) and it may differ from general purpose defaults.
There was a problem hiding this comment.
My question was whether we would like to use 0 here, so that tenant's jobs would be sharded across all compactors by default (even in our setup).
There was a problem hiding this comment.
Right. We can discuss it separately. In this PR I just wanted to upstream the current state.
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
configure-split-and-merge-compactor-in-jsonnet
branch
from
801423e
to
7417f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Now that split-and-merge compactor is the only strategy support, I propose to upstream our config to the OSS mixin.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]