Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: overview: reduce number of queries by 10 #7678

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

krajorama
Copy link
Contributor

What this PR does

Instead of 12 different queries, use 2 in the "Queries / sec" panel. One for known routes combined with overrides for legend and color and one for "other".

This will help introducing native histogram version.

Which issue(s) this PR fixes or relates to

Related to #7154

Checklist

  • N/A Tests updated.
  • N/A Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

@krajorama krajorama requested a review from a team as a code owner March 20, 2024 20:47
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking comment

Instead of 12 different queries, use 2 in the "Queries / sec" panel.
One for known routes combined with overrides for legend and color and
one for "other".

This will help introducing native histogram version.

Signed-off-by: György Krajcsovits <[email protected]>
@krajorama krajorama merged commit bcf9baf into main Mar 21, 2024
31 checks passed
@krajorama krajorama deleted the krajo/fix branch March 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants