Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: native histogram recording rule: cortex_request_duration_seconds #7528

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Mar 4, 2024

What this PR does

Add native histogram recording rule for cortex_request_duration_seconds. This is one of two main histograms that are included in alerts. The new recording rule is required to be able to drop the classic histograms in the mixin.

Which issue(s) this PR fixes or relates to

Related to: #7154

Checklist

  • Tests updated.
  • N/a Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

@krajorama krajorama requested a review from a team as a code owner March 4, 2024 14:28
Add native histogram recording rule for cortex_request_duration_seconds.
This is one of two main histograms that are included in alerts.
The new recording rule is required to be able to drop the classic
histograms in the mixin.

Signed-off-by: György Krajcsovits <[email protected]>
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama merged commit f42f091 into main Mar 4, 2024
31 checks passed
@krajorama krajorama deleted the krajo/fix branch March 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants