Drop useless recording rules for non existent cache metrics #7514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were renamed in Mimir 2.0: cortex_memcache_request_duration_seconds cortex_cache_request_duration_seconds to thanos_memcached_operation_duration_seconds but the corresponding recording rule was not cleared, I think it's time. Since we're going to introduce native histograms for the new metric, we probably don't need to have a recording rule for it - also nobody complained. Signed-off-by: György Krajcsovits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
These were renamed in Mimir 2.0:
cortex_memcache_request_duration_seconds
cortex_cache_request_duration_seconds
to
thanos_memcached_operation_duration_seconds
but the corresponding recording rule was not cleared, I think it's time. Since we're going to introduce native histograms for the new metric, we probably don't need to have a recording rule for it - also nobody complained.
Which issue(s) this PR fixes or relates to
Related to: #7154
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.