Add native histogram support to mimir-mixin #7152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recording rules, alerts, dashboards. Signed-off-by: György Krajcsovits <[email protected]>
Same as for QPS panel. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Otherwise yaxes is changed from "reqps" to "short" in the generated dashboard. Signed-off-by: György Krajcsovits <[email protected]>
1 task
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
commented
Jan 19, 2024
| @@ -99,24 +99,24 @@ local filename = 'mimir-writes.json'; | |||
| .addPanelIf( | |||
| $._config.gateway_enabled, | |||
| $.panel('Requests / sec') + | |||
| $.statPanel('sum(rate(cortex_request_duration_seconds_count{%s, route=~"%s"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.gateway), $.queries.write_http_routes_regex], format='reqps') | |||
| $.statPanel('sum(%s)' % utils.nativeClassicHistogramCountRate($.queries.gateway.writeRequestsPerSecondMetric, $.queries.gateway.writeRequestsPerSecondSelector), format='reqps') | |||
There was a problem hiding this comment.
Note to reviewers: start here.
|
superseded by #7455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Recording rules, alerts, dashboards.
Using the new panel functions added in jsonnet-libs.
Also for the latency percentile panel, switch away from using recorded values as normal values work fine (we use normal values in the per pod latency panel anyway).
Which issue(s) this PR fixes or relates to
Fixes #7154
Related to #4173
Depends on grafana/jsonnet-libs#1121
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.