Vendor update weaveworks/common #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to weaveworks/common@4897cec This prepares exposing Mimir the histogram metric family cortex_request_duration_seconds as native histogram on GRPC. Note that this also aligns the weaveworks common and mimir grpc versions again. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
bboreham
reviewed
May 4, 2023
| @@ -208,7 +209,7 @@ require ( | |||
| github.com/rs/cors v1.9.0 // indirect | |||
| github.com/rs/xid v1.4.0 // indirect | |||
| github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529 // indirect | |||
| github.com/sercand/kuberesolver v2.4.0+incompatible // indirect | |||
| github.com/sercand/kuberesolver/v4 v4.0.0 // indirect | |||
There was a problem hiding this comment.
I think it's worth calling out this change, which was required by the gRPC update, just in case it works differently.
| @@ -1260,8 +1265,8 @@ google.golang.org/genproto/googleapis/rpc/errdetails | |||
| google.golang.org/genproto/googleapis/rpc/status | |||
| google.golang.org/genproto/googleapis/type/date | |||
| google.golang.org/genproto/googleapis/type/expr | |||
| # google.golang.org/grpc v1.53.0 => google.golang.org/grpc v1.47.0 | |||
| ## explicit; go 1.14 | |||
| # google.golang.org/grpc v1.53.0 | |||
There was a problem hiding this comment.
Suggest noting the from/to version numbers in changelog.
| # (advanced) Optionally log requests at info level instead of debug level. | ||
| # CLI flag: -server.log-request-at-info-level-enabled | ||
| [log_request_at_info_level_enabled: <boolean> | default = false] | ||
|
|
||
| [log_request_exclude_headers_list: <string> | default = ""] |
There was a problem hiding this comment.
could go in changelog; some users will like the ability to restrict more headers
There was a problem hiding this comment.
I'm adding a PR in weaveworks common to add the flag description as well.
| @@ -564,10 +564,14 @@ grpc_tls_config: | |||
| # CLI flag: -server.log-source-ips-regex | |||
| [log_source_ips_regex: <string> | default = ""] | |||
|
|
|||
| [log_request_headers: <boolean> | default = ] | |||
There was a problem hiding this comment.
I'm pretty sure I didn't intend for this to be user-visible, but here we are.
3 tasks
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
Merging to unblock myself. Happy to address post-merge feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update to weaveworks/common@102db1b5bbb9
This prepares exposing the histogram metric family cortex_request_duration_seconds as native histogram on GRPC.
Note that this also aligns the weaveworks common and mimir grpc versions again.
Which issue(s) this PR fixes or relates to
Related to #4175
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]