Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup multikv runtime config in all ring configs. #1047

Merged
merged 8 commits into from
Feb 7, 2022
Merged

Conversation

pstibrany
Copy link
Member

What this PR does: This PR fixes setup of multikv runtime config for all rings.

Which issue(s) this PR fixes:

Fixed #996

Checklist

  • Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pkg/mimir/modules.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but there's a failing unit test to investigate. Thanks!

Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Copy link
Member Author

The changes LGTM but there's a failing unit test to investigate. Thanks!

Test started to fail, because we initialized default limits in initRuntimeConfig in new TestMultiKVSetup test. Fixed by resetting default limits to empty value.

@pracucci pracucci merged commit 84cb23d into main Feb 7, 2022
@pracucci pracucci deleted the init-multi-kv branch February 7, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using multi KV Store, runtime config changes are used only in ingester ring.
2 participants