Global markers bucket now deletes both markers, and only reports "Exists" if both markers exists. #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s" if both files exist. Signed-off-by: Peter Štibraný <[email protected]>
pstibrany
force-pushed
the
marker-files
branch
from
6389ec8
to
ecdea7d
Compare
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
replay
reviewed
Feb 3, 2022
replay
reviewed
Feb 3, 2022
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
Feb 3, 2022
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR modifies
globalMarkersBucketin two ways:Deleteon block-local marker file, global marker file is always deleted too, even if block-local marker file doesn't exist.Existson block-local marker file, it returns true only if global marker file exists as well. This helpsMarkForDeletionandMarkForNoCompactfunctions from `github.com/thanos-io/thanos/pkg/block' pacakge to correctly re-upload marker files, if block-local marker already exists, but global marker file doesn't exist.This fixes problem that appears in the log files as:
requested to mark for deletion, but file already exists; this should not happen; investigaterequested to mark for no compaction, but file already exists; this should not happen; investigateDue to above logic, compactor was unable to clean up some blocks properly, which could cause that these blocks remain in the bucket as partial blocks.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]