-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trafficdump tool #1004
Add Trafficdump tool #1004
Conversation
tools/trafficdump/README.md
Outdated
@@ -0,0 +1,13 @@ | |||
Trafficdump tool can read packets from device or from captured tcpdump output, reassemble them into TCP streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdbaldry, did we want to keep this doc in the README.md
file? I think so, but cannot remember.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have this in the technical documentation as "About mimirtool
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split that off into a subsequent issue or PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have this in the technical documentation as "About
mimirtool
"
Relates to #1014.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking, and can update docs later too.
I plan to write a documentation shortly describing all our tools. |
I think it would be useful to have a flag which makes it not show all the warnings and errors, but only the information which it parsed successfully. For example I tested it by doing this:
And it did successfully parse out the metrics of the specified selector, but there was also quite a lot of warning/error noise:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressing tooling! I'm 👍 : it's just a tooling that doesn't interfere with Mimir. You already successfully used it, in my opinion for such tooling there's no need for a deep review, especially if you already successfully used it, so let's get in, let's keep using it and improving over time based on hands-on experience.
See #1098. |
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
…ld image. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Only process packets with src or dest port equal to given value. Reuse buffers for parsing push requests. Synchronize output. Log message when internal queues are full and we need to drop parsed request or response. Signed-off-by: Peter Štibraný <[email protected]>
Co-authored-by: Mauro Stettler <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
- only parse file, no live capturing - only print requests/responses that were parsed successfully by default - expose -ignore-path flag - typos/cleanup Signed-off-by: Peter Štibraný <[email protected]>
… without libpcap. Removed linux build. Signed-off-by: Peter Štibraný <[email protected]>
dae0c6d
to
cf9fa8e
Compare
Signed-off-by: Peter Štibraný <[email protected]>
What this PR does: This PR adds
trafficdump
tool, which can read packets from device or from captured tcpdump output, reassemble them into TCP streams and parse HTTP requests and responses. It then prints requests and responses as json (one request/response par per line) for further processing.It has some Mimir-specific and generic HTTP features:
Trafficdump can be used to inspect both remote-write requests and queries.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]