Change memcached client default timeout setting #1000
Conversation
ortuman
force-pushed
the
ortuman/change-memcached-default-timeout
branch
from
b4f533d
to
84c641c
Compare
ortuman
force-pushed
the
ortuman/change-memcached-default-timeout
branch
from
84c641c
to
2463ca3
Compare
| @@ -242,6 +242,11 @@ | |||
| * `-blocks-storage.bucket-store.index-cache.memcached.max-idle-connections` | |||
There was a problem hiding this comment.
I just noticed the indentation of the sublists above is wrong. Can you fix them too, please?
There was a problem hiding this comment.
That must be very subtle.
Maybe my eye is betraying me, but after reviewing, that list seems to have the same indentation level as the rest. 🤔
There was a problem hiding this comment.
I think this might be some rendering issue on GitHub, when checking out the code it looks the same as the others to me
There was a problem hiding this comment.
Could be. I'm going to merge this PR and I will double check it, just in case.
There was a problem hiding this comment.
Yeah, I can't see anything wrong locally and it also renders fine here:
https://github.com/grafana/mimir/blob/main/CHANGELOG.md
What this PR does:
*.memcached.timeoutto200msWhich issue(s) this PR fixes:
Fixes grafana/mimir-squad#495
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]