-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add out-of-order sample support to the TSDB #269
Conversation
This replaces #268. Somehow having a single commit while manually adding co-authors removes the CLA requirement from the co-authors. (See 268, CLA fails because Dieter hasn't signed, but it does not fail here). |
We can consider merging this after #270 is merged and synced in this PR. |
Lets get the OOOAllowance changes and the OOO WBL dir rename into this PR. |
22b25f4
to
260ee0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did take a look at some of the TODO comments that we can get rid of. Can you take a look at the comments @codesome?
Opened #273 for TODOs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preemptively approving knowing that you will rebase this PR with the changes from #273
Let's goooo 🎉 🎉 🎉 🎉
This implementation is based on this design doc: https://docs.google.com/document/d/1Kppm7qL9C-BJB1j6yb6-9ObG3AbdZnFUBYPNNWwDBYM/edit?usp=sharing This commit adds support to accept out-of-order ("OOO") sample into the TSDB up to a configurable time allowance. If OOO is enabled, overlapping querying are automatically enabled. Signed-off-by: Ganesh Vernekar <[email protected]> Co-authored-by: Jesus Vazquez <[email protected]> Co-authored-by: Ganesh Vernekar <[email protected]> Co-authored-by: Dieter Plaetinck <[email protected]>
This PR changes |
Did this mean TSDB that supports out of order data is not compatible with thanos? So I can't use it in cortex v1.11 that supports obs storage? |
@nwpuCfy that comment was about code interface and not the data format. Thanos has switched to the new interface I think. And they use prometheus/prometheus, and not grafana/mimir-prometheus. |
thanks for reply |
This implementation is based on this design doc:
https://docs.google.com/document/d/1Kppm7qL9C-BJB1j6yb6-9ObG3AbdZnFUBYPNNWwDBYM/edit?usp=sharing
This commit adds support to accept out-of-order ("OOO") sample into the TSDB
up to a configurable time allowance. If OOO is enabled, overlapping querying
are automatically enabled.