This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Improve performance of metatag doesnt exist expr #1920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1871
This PR's branch is based on top of the branch of PR #1898, it only makes sense to review this PR once #1898 is merged.
This adds an optimization which is specific for queries that query for the absence of a meta tag of which all underlying expressions are using the
=
operator. This optimization currently already exists for queries which query for the presence of a meta tag using=
and of which all underlying expressions are also using the=
operator, in this PR that existing optimization gets extended to also work for filter expressions which check for the absence of a meta tag.I also added a benchmark to test for that specific case, and It shows significant improvements with/without this change: