Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Add timeShift natively #1873

Merged
merged 13 commits into from
Aug 24, 2020
Merged

Add timeShift natively #1873

merged 13 commits into from
Aug 24, 2020

Conversation

shanson7
Copy link
Collaborator

@shanson7 shanson7 commented Aug 6, 2020

Describe your changes
Implement timeShift natively

Testing performed
test files added
A/B testing against graphite using https://github.com/shanson7/mtcmptest

Additional context
There are a few scenarios that are a little strange:

  1. resetToEnd does not seem to work when data is retrieved from MT (whether by graphite or natively). I think it's due to padding the data to the requested end.
  2. alignToDST is hard to test on UTC servers :) It uses the server timezone (which I think is misleading to users) and that may be different in the Mt deploy than the graphite deploy

@robert-milan
Copy link
Contributor

I agree, we can leave support out for resetEnd. Other than that it looks good. I tested it locally. Just need to fix the conflicts and I think it is ready for merge.

@Dieterbe Dieterbe self-assigned this Aug 24, 2020
@Dieterbe Dieterbe added this to the sprint-16 milestone Aug 24, 2020
@Dieterbe Dieterbe merged commit 8ad61d3 into grafana:master Aug 24, 2020
@shanson7 shanson7 deleted the timeShift_take2 branch October 22, 2021 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants