full cirlce #997
Merged
full cirlce #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
approved these changes
Sep 9, 2019
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…fana#997) * Defer converting from LabelPairs to Metric until needed Since we average hundreds of samples to a chunk, it saves a lot of work to leave label name/value sets as the slice they come in as, rather than converting to the map type that Prometheus uses. They are converted on flush, to avoid changing the chunk store. * Store labelPairs in series sorted, for faster lookup * Extract BenchmarkMetric as re-usable fixture for tests * Add benchmark for Ingester Push() * Copy name/value bytes, to avoid keeping the gRPC buffer alive
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…ush (grafana#997)" Seeing `ValidationException` errors from DynamoDB. This reverts commit 3e8dfbb27cfbe717511a59a8b9a6abc48bc11fc8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.