Logcli: Add Support for New Query Path #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
|
|
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
docs/logcli.md
Outdated
|
|
||
| Args: | ||
| <query> eg '{foo="bar",baz="blip"}' | ||
| [<regex>] | ||
| <query> eg '{foo="bar",baz="blip"}' |
There was a problem hiding this comment.
can you add a sample query with a regex filter ?
There was a problem hiding this comment.
Regex example added to the help output as well as the documentation. Sample query changed to:
'{foo="bar",baz=~".*blip"}'
There was a problem hiding this comment.
This is also nice but I meant '{foo="bar",baz=~".*blip"} |~ ".*error.*"' since we removed the regex argument.
There was a problem hiding this comment.
Requested query added.
cyriltovena
approved these changes
Sep 11, 2019
2 tasks
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
query_rangeapi.Which issue(s) this PR fixes:
Special notes for your reviewer:
The refactor was a medium effort, medium value, low risk change. Certainly more time could be spent building a better, more generic Loki API client for future use.
Checklist