Add pipeline unit testing to promtail #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slim-bean Kindly let me know if the changes are relevant to what you mentioned in #769. If not, let me know what exactly should be done. Thanks! Note: The code in this PR still needs some refactoring |
adityacs
force-pushed
the
master
branch
5 times, most recently
from
c2022e8 to
bbeb1d4
Compare
|
yes this is exactly what I had in mind! let me know when you are ready and I'll review! |
adityacs
force-pushed
the
master
branch
2 times, most recently
from
fd2ecd1 to
3cc2184
Compare
|
@slim-bean Kindly review this |
slim-bean
reviewed
Aug 14, 2019
slim-bean
reviewed
Aug 14, 2019
pkg/promtail/promtail_test.go
Outdated
| labels.Label{ | ||
| Name: "action", | ||
| Value: "GET", | ||
| }, |
There was a problem hiding this comment.
can you flatten these out to save a little vertical space:
labels.Label{Name: "action", Value: "GET"},
slim-bean
reviewed
Aug 14, 2019
|
@slim-bean Have made the changes. Kindly review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it ?:
Add pipeline unit testing to promtail
Which issue(s) this PR fixes:
Fixes #769