Pipeline: Fixed labels process test with same objects #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jojohappy <[email protected]>
|
|
slim-bean
reviewed
Aug 8, 2019
pkg/logentry/stages/labels_test.go
Outdated
| @@ -158,7 +158,7 @@ func TestLabelStage_Process(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
| st.Process(test.inputLabels, test.extractedData, nil, nil) | |||
| assert.Equal(t, test.expectedLabels, test.expectedLabels) | |||
| assert.Equal(t, test.inputLabels, test.expectedLabels) | |||
There was a problem hiding this comment.
Can you swap these around?
func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{})
So that test.expectedLabels is first and test.inputLabels is second, this will make any failure messages a little easier to understand.
|
Yikes! good catch! One little nit and we'll get this merged! |
Signed-off-by: jojohappy <[email protected]>
|
@slim-bean Thanks for your review! |
slim-bean
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy [email protected]
What this PR does / why we need it:
Fixed the labels test to compare the same excepted objects.