-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus dependency to latest release (v2.40.4) #7826
Conversation
Hm, this is failing on the protobufs:
I'm not sure what I should do here; I think it might be related to @krajorama's resent changes to weaveworks/common but I can't tell. |
Yes, we've fixed non-reproducable build in weaveworks/common#264 and weaveworks/common#265 . See comment here on knock on effect: weaveworks/common#262 (comment) TL;DR; you need to have a |
@krajorama Thanks! Looks like there was two set of issues:
|
f442ea1
to
8114d47
Compare
faillint needs an update for Go 1.19 where it fails unexpectedly. First observed in grafana#7826. See fatih/faillint#36
faillint needs an update for Go 1.19 where it fails unexpectedly. First observed in #7826. See fatih/faillint#36
33963f2
to
ac1db91
Compare
ac1db91
to
65c09cc
Compare
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for putting in all the effort to make this change @rfratto !
Closes #7811, which is needed for Grafana Agent to update to v2.40 and add support for native histograms.
I did not add support for native histograms to Loki, sorry :)