Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Add TLS support for compactor client #7448

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Oct 18, 2022

What this PR does / why we need it:
Add operator support for #7426 and #7453 when HTTPEncryption feature gate on.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Image for testing that includes #7453: docker.io/theperiklis/loki:operator-delete-client-tls-0b5e32f

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@periklis periklis self-assigned this Oct 18, 2022
@periklis periklis requested a review from a team as a code owner October 18, 2022 11:40
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@periklis periklis changed the title operator: Add TLS support for compactor delete client operator: Add TLS support for compactor clients Oct 18, 2022
@periklis periklis changed the title operator: Add TLS support for compactor clients WIP: operator: Add TLS support for compactor clients Oct 18, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@periklis periklis changed the title WIP: operator: Add TLS support for compactor clients operator: Add TLS support for compactor clients Oct 19, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 4, 2022
@periklis periklis changed the title operator: Add TLS support for compactor clients operator: Add TLS support for compactor client Nov 4, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@periklis periklis merged commit 7ec072d into grafana:main Nov 4, 2022
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants