-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document setting up command completion for logcli #7325
docs: Document setting up command completion for logcli #7325
Conversation
To see if this error is consistent: ``` + make BUILD_IN_CONTAINER=false validate-example-configs ... Validating provided example config: ./docs/sources/configuration/examples/bos-config.yaml bash: ./cmd/loki/loki: Text file busy ```
Seeing if this error is consistent, since I can't reproduce locally: ``` --- FAIL: TestSingleBinaryIngestQuery (0.01s) loki_single_binary_test.go:28: Error Trace: /src/loki/integration/loki_single_binary_test.go:28 Error: Received unexpected error: error starting component all: error initialising module: server: listen tcp :45253: bind: address already in use Test: TestSingleBinaryIngestQuery ```
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I've added it to my .zshrc :). Thanks for adding this.
This documents the existing command completion that kingpin provides (docs [here](https://github.com/alecthomas/kingpin#bashzsh-shell-completion) on that). **Which issue(s) this PR fixes**: Fixes grafana#2949
This documents the existing command completion that kingpin provides (docs [here](https://github.com/alecthomas/kingpin#bashzsh-shell-completion) on that). **Which issue(s) this PR fixes**: Fixes grafana#2949
This documents the existing command completion that kingpin provides (docs [here](https://github.com/alecthomas/kingpin#bashzsh-shell-completion) on that). **Which issue(s) this PR fixes**: Fixes grafana#2949
What this PR does / why we need it:
This documents the existing command completion that kingpin provides (docs here on that).
Which issue(s) this PR fixes:
Fixes #2949
Special notes for your reviewer:
Please feel free to adjust/reword any of this! I thought I would give it a shot. I ran
make docs
too, and confirmed the formatting looked good. Hugo even indented the code blocks under the bullet points. 😮Checklist
CONTRIBUTING.md
guideCHANGELOG.md
updateddocs/sources/upgrading/_index.md