Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki] Azure auth using Service Principal #7179

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

vlad-diachenko
Copy link
Contributor

@vlad-diachenko vlad-diachenko commented Sep 16, 2022

What this PR does / why we need it:

This PR adds the ability to use Service Principal credentials to authenticate through Azure OAuth. It might be needed when we want to access Azure Blob storage from another tenant.
Previously we could use only StorageAccount key that can not be used cross-tenant.
Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@vlad-diachenko vlad-diachenko requested a review from a team as a code owner September 16, 2022 07:07
@vlad-diachenko vlad-diachenko changed the title [loki] Azure auth using Service Principal Sep 16, 2022
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Michel Hollands <[email protected]>
@vlad-diachenko vlad-diachenko merged commit 7f629c8 into main Sep 16, 2022
@vlad-diachenko vlad-diachenko deleted the azure_service_principal_auth branch September 16, 2022 10:13
owen-d added a commit that referenced this pull request Sep 16, 2022
MichelHollands added a commit that referenced this pull request Oct 24, 2022
Add documentation for #7179 which
added authentication using a Service Principal for Azure.
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
This PR adds the ability to use Service Principal credentials to
authenticate through Azure OAuth. It might be needed when we want to
access Azure Blob storage from another tenant.
Previously we could use only StorageAccount key that can not be used
cross-tenant.
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
Add documentation for grafana#7179 which
added authentication using a Service Principal for Azure.
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
Add documentation for grafana#7179 which
added authentication using a Service Principal for Azure.
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
Add documentation for grafana#7179 which
added authentication using a Service Principal for Azure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants