[TSDB] Ingester Index Sampling #6852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
…ing-impl Signed-off-by: Owen Diehl <[email protected]>
…refactor Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. - ingester -1%
+ distributor 0%
- querier -1.1%
+ querier/queryrange 0%
+ iter 0%
- storage -1.3%
+ chunkenc 0%
+ logql 0%
+ loki 0.6% |
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
* queryrangebase definitions protos & aliases Signed-off-by: Owen Diehl <[email protected]> * indexgatewaypb to logproto Signed-off-by: Owen Diehl <[email protected]> * updates queryrange.proto for new definitions file Signed-off-by: Owen Diehl <[email protected]> * s/indexgatewaypb/logproto/g Signed-off-by: Owen Diehl <[email protected]> * renames to indexseries for clobbering reasons Signed-off-by: Owen Diehl <[email protected]> * more indexgatewaypb removal compatibility work Signed-off-by: Owen Diehl <[email protected]> * proto fmt Signed-off-by: Owen Diehl <[email protected]> * rebuild imports Signed-off-by: Owen Diehl <[email protected]> * goimports -s Signed-off-by: Owen Diehl <[email protected]> * query ingesters for index stats Signed-off-by: Owen Diehl <[email protected]> * compatibility during rollouts for idx-gw+ingester-querier post proto refactor Signed-off-by: Owen Diehl <[email protected]> * proto compatibility with old indexgateway pkg path Signed-off-by: Owen Diehl <[email protected]> * test compat Signed-off-by: Owen Diehl <[email protected]> * gofmt Signed-off-by: Owen Diehl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
indexgatewaypbpackage. While [TSDB] Indexgateway Protobuf refactor #6841 ensured the payloads were compatible, the grpc service description generated didn't match the historicalindexgatewaypb.IndexGateway, which caused errors when trying to query the old index gateways with new queriers. This PR moves theIndexGatewayservice into it's own proto package with the nameindexgatewaypband generates code in thelogprotogolang package, which fixes errors during rollouts as the service descriptions now match.