Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache usage statistics #6317

Merged
merged 11 commits into from
Jun 7, 2022
Merged

Add cache usage statistics #6317

merged 11 commits into from
Jun 7, 2022

Commits on Jun 6, 2022

  1. Adding cache statistics 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    b5c496d View commit details
    Browse the repository at this point in the history

  2. Adding metrics to metrics.go 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    438581e View commit details
    Browse the repository at this point in the history

  3. Creating new stats context for use in metric queries middleware 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    baa239c View commit details
    Browse the repository at this point in the history

  4. Clean up unnecessary log fields 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    f56d642 View commit details
    Browse the repository at this point in the history

  5. Fixing tests 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    4e9fafb View commit details
    Browse the repository at this point in the history

  6. Adding stats tests 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    648b335 View commit details
    Browse the repository at this point in the history

  7. CHANGELOG entry 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    6cb5665 View commit details
    Browse the repository at this point in the history

  8. Appeasing the linter 

    Documenting function

Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    311e89b View commit details
    Browse the repository at this point in the history

  9. Moving CHANGELOG entry to appropriate section 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    9aa789e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Implementing a stats collector cache wrapper to simplify stats collec… 

    …tion

If we keep the stats collection in pkg/storage/chunk/cache/instrumented.go, then any implementation that wraps it will cause the stats collected to be incomplete. For example: NewBackground(cacheName, cfg.Background, Instrument(cacheName, cache, reg), reg)) - the background cache requests are not collected

Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    769145d View commit details
    Browse the repository at this point in the history

  2. Fixing tests 

    Signed-off-by: Danny Kopping <[email protected]>
    Danny Kopping committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b966286 View commit details
    Browse the repository at this point in the history