promtail: Add support for exclusion patterns in static_config
#5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
commented
Apr 18, 2022
| if fi, err := os.Stat(t.pathExclude); err == nil && !fi.IsDir() { | ||
| matchesExcluded = []string{t.pathExclude} | ||
| } else { | ||
| matchesExcluded, err = doublestar.Glob(t.pathExclude) |
There was a problem hiding this comment.
If t.pathExclude is empty, then doublestar.Glob returns nil, nil, just skipping the loop below.
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
This reverts commit 17abb006ce141071c4bca4b7d133bea2aa314594.
tpaschalis
force-pushed
the
add-promtail-exclusion
branch
from
8a30ff2
to
838a8e3
Compare
This was referenced Jun 28, 2022
|
is it please possible to make it exclude two files resp. two different logfiles with no common root (how about 3)? |
|
@adam0s9 hey there 👋 Right now this is not possible with the If you'd like to propose an enhancement to the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paschalis Tsilias [email protected]
What this PR does / why we need it:
As stated in the linked Issue, there's currently no easy way to exclude files from a Promtail config, except for overly restrictive and/or complex glob patterns.
This addition may be helpful in a number of scenarios, from avoiding usage spikes in Grafana cloud, to having separate pipeline_stages for specific file formats, or filtering directories which Promtail couldn't tail due to permissions.
Since the upstream bmatcuk/doublestar package doesn't support negation patterns, this is another way of achieving the same result.
Which issue(s) this PR fixes:
Fixes #5744
Special notes for your reviewer:
From my local tests, this seems to work as intended both in scrape_config and file_sd_config blocks; let me know if I've missed anything ^^
Checklist
CHANGELOG.mdabout the changes.