-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fluent-bit output name #5711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hollands <[email protected]>
dannykopping
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KMiller-Grafana
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MasslessParticle
added
the
backport release-2.5.x
Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch
label
Apr 7, 2022
grafanabot
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Update fluent-bit output name Signed-off-by: Michel Hollands <[email protected]> * Empty commit * Another empty commit (cherry picked from commit 9d62f05)
MasslessParticle
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Update fluent-bit output name Signed-off-by: Michel Hollands <[email protected]> * Empty commit * Another empty commit (cherry picked from commit 9d62f05) Co-authored-by: Michel Hollands <[email protected]>
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
* Update fluent-bit output name Signed-off-by: Michel Hollands <[email protected]> * Empty commit * Another empty commit (cherry picked from commit 9d62f05) Co-authored-by: Michel Hollands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release-2.5.x
Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch
size/XS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The configuration of the Fluent Bit plugin uses
grafana-loki
as output name. In the documentation for ECSloki
is used wrongly. This PR updates the ECS example to usegrafana-loki
as well.Checklist
CHANGELOG.md
about the changes.Signed-off-by: Michel Hollands [email protected]