-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtail: Fix retry/stop when erroring for out of cloudflare retention range (e.g. over 168 hours old) #5698
Promtail: Fix retry/stop when erroring for out of cloudflare retention range (e.g. over 168 hours old) #5698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it 🙂
@dannykopping or @jeschkies not sure about the recent test failure appears to be a cleanup issue with that one run, any way to restart it without changing something in code? |
@dannykopping, @cstyan or @jeschkies anything else you need me to do to accept this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once CI completes.
Thanks for your patience on this one @paullryan and for the fix!
CI has completed, but GH is not acknowledging its completion; merging in spite of this... |
@dannykopping thank you for working with me to complete this will be very helpful in my org. |
…n range (e.g. over 168 hours old) (#5698) (#5782) * fix: 5696 don't retry when out of range for cloudflare (cherry picked from commit 4e3f3b7) Co-authored-by: Paul Ryan <[email protected]>
…n range (e.g. over 168 hours old) (grafana#5698) (grafana#5782) * fix: 5696 don't retry when out of range for cloudflare (cherry picked from commit 4e3f3b7) Co-authored-by: Paul Ryan <[email protected]>
What this PR does / why we need it:
Fixes the new cloudflare scrape in promtail for when loki tries to pull logs that are older than 168 hours, this is not allowed by the cloudflare api and right now is causing loki to stop reading logs in the future instead of ignoring and moving on.
Which issue(s) this PR fixes:
Fixes #5696
Special notes for your reviewer:
@cyriltovena I'm unsure if I missed a case here, please let me know.
Checklist
CHANGELOG.md
about the changes.