Correctly sets hash value for headblock iterator #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Welch <[email protected]>
kavirajk
pushed a commit
that referenced
this pull request
Feb 18, 2022
kavirajk
added a commit
that referenced
this pull request
Feb 18, 2022
* Correctly sets hash value for headblock iterator (#5423) * Do not use WaitGroup context for StepEvaluator (#5425) Co-authored-by: Cyril Tovena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When doing https://github.com/grafana/loki/pull/5289/files I actually missed to properly set the hash for headblocks.
This result in ingesters not sending the hash for really fresh data (uncut block) and so queriers will not dedupe accordingly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.