Write Promtail position file atomically. #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| err = ioutil.WriteFile(temp, buf, os.FileMode(positionFileMode)) | ||
| err = renameio.WriteFile(target, buf, os.FileMode(positionFileMode)) |
There was a problem hiding this comment.
https://github.com/google/renameio#windows-support
According to this, we should probably special-case Windows here. What do you think?
There was a problem hiding this comment.
I wanted to reference it. You were faster. I think so. We should use the old version on Windows.
jeschkies
commented
Jan 28, 2022
|
|
||
| err = ioutil.WriteFile(temp, buf, os.FileMode(positionFileMode)) | ||
| err = renameio.WriteFile(target, buf, os.FileMode(positionFileMode)) |
There was a problem hiding this comment.
I wanted to reference it. You were faster. I think so. We should use the old version on Windows.
chaudum
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This uses
renameiothat supports writing files atomically.Which issue(s) this PR fixes:
Fixes #5218
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.