Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move querier.split-queries-by-interval to a per-tenant configuration #5023

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

ssncferreira
Copy link
Contributor

@ssncferreira ssncferreira commented Dec 31, 2021

What this PR does / why we need it:

  • Move querier.split_queries_by_interval configuration flag to per-tenant limits
  • Remove configuration check on the frontend's tripperware instantiation code

Which issue(s) this PR fixes:
Fixes #5014

Special notes for your reviewer:

Checklist

  • Documentation updated
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@ssncferreira ssncferreira force-pushed the issue/5014-split_queries_by_interval_per_tenant branch 3 times, most recently from daa7e1f to 5ad164a Compare December 31, 2021 14:43
@ssncferreira ssncferreira force-pushed the issue/5014-split_queries_by_interval_per_tenant branch from 5ad164a to c4fc053 Compare December 31, 2021 15:29
@ssncferreira ssncferreira self-assigned this Dec 31, 2021
@ssncferreira ssncferreira marked this pull request as ready for review December 31, 2021 15:46
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice !

@cyriltovena cyriltovena merged commit 2fdd240 into main Jan 3, 2022
@cyriltovena cyriltovena deleted the issue/5014-split_queries_by_interval_per_tenant branch January 3, 2022 13:56
james-callahan added a commit to james-callahan/kustomize-loki that referenced this pull request Jan 11, 2022
james-callahan added a commit to james-callahan/kustomize-loki that referenced this pull request Jan 14, 2022
james-callahan added a commit to james-callahan/kustomize-loki that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated/confusing parallelization code
2 participants