Add GELF support for Promtail. #4744
Conversation
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
changed the title
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
|
|
||
| ``` | ||
|
|
||
| **Available Labels:** |
There was a problem hiding this comment.
I'm suprised you don't expose the extra fields as e.g. __gelf_message_extra_<name>
There was a problem hiding this comment.
Created an issue #4846
| // Add all labels from the config. | ||
| for k, v := range t.config.Labels { | ||
| lb.Set(string(k), string(v)) | ||
| } |
There was a problem hiding this comment.
Isn't this the same for each message? Why is it done each time?
There was a problem hiding this comment.
To ensure label are clone and not mutated after. Might not be required.
| The `gelf` block configures a GELF UDP listener allowing users to push | ||
| logs to Promtail with the [GELF](https://docs.graylog.org/docs/gelf) protocol. |
There was a problem hiding this comment.
Does this mean Promtail has a continuous connection with a server? What's happening when it fails?
There was a problem hiding this comment.
Promtail is the server.
There was a problem hiding this comment.
And there's no connection in UDP.
There was a problem hiding this comment.
Ah, it's been a long time that I've looked at UDP 🙈
What this PR does / why we need it:
This PR adds support for GELF UDP protocol to listen and send GELF message to Loki.
Which issue(s) this PR fixes:
Fixes #4743
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.