Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensures components with required SRV lookups use the correct port #4737

Merged
merged 2 commits into from
Nov 11, 2021
Merged

ensures components with required SRV lookups use the correct port #4737

merged 2 commits into from
Nov 11, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 11, 2021

The ensure we create ports & thus SRV records in k8s with the expected _grpclb prefix

@owen-d owen-d requested a review from a team as a code owner November 11, 2021 16:40
slim-bean
slim-bean approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d merged commit 0116aa6 into grafana:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@dannykopping dannykopping dannykopping approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-d @dannykopping @slim-bean