Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to dskit/ring #4641

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Migration to dskit/ring #4641

merged 1 commit into from
Nov 4, 2021

Conversation

ssncferreira
Copy link
Contributor

@ssncferreira ssncferreira commented Nov 4, 2021 •
edited
Loading

What this PR does / why we need it:

Migrate loki to use dskit/ring. Required also cortexproject/cortex update.

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ssncferreira ssncferreira force-pushed the dskit-ring branch 3 times, most recently from 01e3b34 to 4513d64 Compare November 4, 2021 12:30
owen-d
owen-d approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@owen-d owen-d marked this pull request as ready for review November 4, 2021 13:13
@owen-d owen-d requested a review from a team as a code owner November 4, 2021 13:13
@owen-d owen-d merged commit 2d24e2e into main Nov 4, 2021
@owen-d owen-d deleted the dskit-ring branch November 4, 2021 14:29
@ssncferreira ssncferreira mentioned this pull request Nov 5, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssncferreira @CLAassistant @owen-d