Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: Change default RejectOldSamplesMaxAge from 14d to 7d #4569

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Config: Change default RejectOldSamplesMaxAge from 14d to 7d #4569

merged 1 commit into from
Oct 29, 2021

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Oct 27, 2021 •
edited
Loading

What this PR does / why we need it:
In PR 4415 I was supposed to change RejectOldSamplesMaxAge default value from 14d to 7d (it is even listed in the upgrading guide). However, I overlooked it and merged it with the previous value.

Checklist

  • Documentation added (docs are already correct)
  • Tests updated

@DylanGuedes DylanGuedes requested a review from a team as a code owner October 27, 2021 15:32
cyriltovena
cyriltovena approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 3ab7bcd into grafana:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
2.4 size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanGuedes @cyriltovena @owen-d