Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove ListObjects S3 permission #4499

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Docs: Remove ListObjects S3 permission #4499

merged 1 commit into from
Oct 20, 2021

Conversation

vdm
Copy link
Contributor

@vdm vdm commented Oct 19, 2021

What this PR does / why we need it:

On this documentation page "s3:ListObjects" is incorrectly listed as an S3 permission.

ListObjects is not an S3 IAM Action, it is only an API which uses the s3:ListBucket IAM Action.

Which issue(s) this PR fixes:
None

Checklist

  • Documentation added

ListObjects is not an S3 permission, it is an API which uses the s3:ListBucket permission.
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs change looks good to me.

@KMiller-Grafana KMiller-Grafana requested a review from a team October 20, 2021 17:14
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR - thanks for the links and description.

@owen-d owen-d merged commit 517ba7c into grafana:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants