auto-apply memberlist ring config when join_members provided #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
force-pushed
the
populate-memberlist
branch
from
e1ca359
to
f4e7a30
Compare
trevorwhitney
force-pushed
the
populate-memberlist
branch
2 times, most recently
from
8bc0f45
to
a801881
Compare
kavirajk
approved these changes
Oct 7, 2021
|
@trevorwhitney my only nit would be to include a brief comment with basically what you summarized in the PR As this common config block grows it's gonna be a tangled web of us manipulating config and any insight I think will go a long away to help our furture selves. |
owen-d
approved these changes
Oct 7, 2021
Signed-off-by: Trevor Whitney <[email protected]>
Signed-off-by: Trevor Whitney <[email protected]>
Signed-off-by: Trevor Whitney <[email protected]>
trevorwhitney
force-pushed
the
populate-memberlist
branch
from
bdc07d1
to
f4a68c4
Compare
2 tasks
Signed-off-by: Trevor Whitney <[email protected]>
|
@owen-d docs added. It seemed from previous PRs that the configuration docs are updated by hand (which I did), but if they're auto-generated from somewhere else please let me know and I'll update the source. |
owen-d
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trevor Whitney [email protected]
What this PR does / why we need it:
This PR will change the default ingester, distributor, and ruler ring configurations to use memberlist if
-memberlist.join_membersin provided. The idea here is that if a user explicitly configured thememberlistconfiguration section, they probably want to be using memberlist for their various ring configurations. Since a user can still explicitly override a specific ring configuration (for example, use consul for the distributor), it seems pretty harmless to take a guess at better defaults here.Checklist