default chunk target size to ~1MB~ 1.5MB #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Whitney <[email protected]>
Signed-off-by: Trevor Whitney <[email protected]>
trevorwhitney
changed the title
owen-d
approved these changes
Sep 29, 2021
|
please update new default in configuration doc: https://grafana.com/docs/loki/latest/configuration/#ingester_config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trevor Whitney [email protected]
What this PR does / why we need it:
Set the default value of
-ingester.chunk-target-sizeto1MB1.5MB.Originally had this at 1MB, after talking to @slim-bean decided 1.5MB. Whatever the value is, 0 is not a good default, forcing a user to always configure this.