remove empty streams after wal replay #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
reviewed
Sep 7, 2021
| @@ -220,9 +220,17 @@ func (r *ingesterRecoverer) Close() { | |||
|
|
|||
| for _, inst := range r.ing.getInstances() { | |||
| inst.forAllStreams(context.Background(), func(s *stream) error { | |||
| s.chunkMtx.Lock() | |||
| defer s.chunkMtx.Unlock() | |||
There was a problem hiding this comment.
I traced through some of the paths that are taken by ConvertHead below but it branches out a little bit. I'm wondering if it would be safer to explicitly just lock and unlock around the conditional below rather than using defer?
There was a problem hiding this comment.
Given that the new code also does a return, I guess weigh this against having to unlock in 2 places vs defer. six and one half dozen....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors stream removal into it's own function and removes empty streams after WAL replay completes in order to not interfere with tenant stream limits during rollout.