Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds loki_ingester_wal_replay_active metric and records this more acc… #4193

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 18, 2021

Adds an easier metric to determine if the WAL is currently replaying and uses sync.Once to ensure we can finish it at the earliest possible time but also take advantage of defer guarantees.

@owen-d owen-d requested a review from a team as a code owner August 18, 2021 22:50
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 9cdb129 into grafana:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants