-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min_sharding_lookback limits to the frontends #4047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
dannykopping
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
added a commit
that referenced
this pull request
Jul 26, 2021
* Add min_sharding_lookback limits to the frontends Signed-off-by: Cyril Tovena <[email protected]> * improve doc. Signed-off-by: Cyril Tovena <[email protected]> * lint Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
added a commit
that referenced
this pull request
Jul 26, 2021
* Add min_sharding_lookback limits to the frontends Signed-off-by: Cyril Tovena <[email protected]> * improve doc. Signed-off-by: Cyril Tovena <[email protected]> * lint Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
added a commit
that referenced
this pull request
Jul 26, 2021
* Add min_sharding_lookback limits to the frontends Signed-off-by: Cyril Tovena <[email protected]> * improve doc. Signed-off-by: Cyril Tovena <[email protected]> * lint Signed-off-by: Cyril Tovena <[email protected]>
KMiller-Grafana
added a commit
to KMiller-Grafana/loki
that referenced
this pull request
Jul 26, 2021
Docs edit of prose from grafana#4047.
owen-d
added a commit
that referenced
this pull request
Jul 27, 2021
* Clarify prose about querier frontend min-sharding-lookback Docs edit of prose from #4047. * Update docs/sources/configuration/_index.md Co-authored-by: Danny Kopping <[email protected]> Co-authored-by: Owen Diehl <[email protected]> Co-authored-by: Danny Kopping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to skip sharding for recent time range. For example if the value is set to 1h,
all queries for the given tenant that are between now and now-1h are not sharded.
Signed-off-by: Cyril Tovena [email protected]