Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retention label to loki_distributor_bytes_received_total metrics #3840

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Add retention label to loki_distributor_bytes_received_total metrics #3840

merged 8 commits into from
Jul 1, 2021

Conversation

cyriltovena
Copy link
Contributor

This add the retention hours to our loki_distributor_bytes_received_total metrics which allows how much data fits for each type of retention per users.

This has been tested in a dev env see below:

image

Signed-off-by: Cyril Tovena [email protected]

dannykopping
dannykopping approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

owen-d
owen-d reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really worried about the cardinality concerns here of exposing distributors * tenants * retention_configs here. Can we encode this into logs instead?

clients/pkg/promtail/targets/lokipush/pushtarget.go Outdated Show resolved Hide resolved
@cyriltovena
Copy link
Contributor Author

I'm really worried about the cardinality concerns here of exposing distributors * tenants * retention_configs here. Can we encode this into logs instead?

This is an internal decision. Ping me if you want to know more.

@cyriltovena
Fixes bad merge.
49ecb35 
Signed-off-by: Cyril Tovena <[email protected]>
@cyriltovena cyriltovena merged commit 22dcfcd into grafana:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d left review comments

@KMiller-Grafana KMiller-Grafana KMiller-Grafana approved these changes

@dannykopping dannykopping dannykopping approved these changes

Assignees
No one assigned
Labels
size/L size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyriltovena @dannykopping @owen-d @KMiller-Grafana