Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revendor compatibility: various prom+k8s+cortex #3664

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Apr 28, 2021

  • Updates the following: prometheus/{common,prometheus}, k8s.io/{client-go,api} (these update to a more recent version than cortex uses because we use additional library functionality that's incompatible with what they use),
  • Removes outdated replace directives for the following: go-openapi/{errors,validate}
  • Removes an erroneous config that we're still applying correctly but were unnecessarily passing to the cortex frontend constructor (t.Cfg.Frontend.CompressResponses - we should pivot to the cortex paradigm they use in the api pkg though).
  • Noop MaxChunksPerQueryFromStore in our limits to satisfy cortex interface.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit d88f399 into grafana:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants