Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loli: Make the store field public #3602

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

MichelHollands
Copy link
Contributor

Used for LBAC.

Signed-off-by: Michel Hollands [email protected]

Signed-off-by: Michel Hollands <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #3602 (fc3f5a6) into master (0107a11) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   63.24%   63.22%   -0.03%     
==========================================
  Files         206      206              
  Lines       17774    17774              
==========================================
- Hits        11242    11238       -4     
- Misses       5533     5537       +4     
  Partials      999      999              
Impacted Files Coverage Δ
pkg/loki/loki.go 0.00% <ø> (ø)
pkg/loki/modules.go 2.75% <0.00%> (ø)
pkg/canary/comparator/comparator.go 76.36% <0.00%> (-1.82%) ⬇️
pkg/logql/evaluator.go 89.83% <0.00%> (-0.36%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 56af725 into grafana:master Apr 13, 2021
@MichelHollands MichelHollands deleted the make_store_public branch April 13, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants