Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds distributor replication factor metric #3594

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Apr 8, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #3594 (41a18da) into master (28d88b3) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3594   +/-   ##
=======================================
  Coverage   63.22%   63.23%           
=======================================
  Files         206      206           
  Lines       17774    17790   +16     
=======================================
+ Hits        11238    11249   +11     
- Misses       5535     5539    +4     
- Partials     1001     1002    +1     
Impacted Files Coverage Δ
pkg/distributor/distributor.go 79.39% <94.44%> (+2.21%) ⬆️
pkg/querier/queryrange/limits.go 86.66% <0.00%> (-1.91%) ⬇️
pkg/ingester/checkpoint.go 72.83% <0.00%> (-1.14%) ⬇️

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 965d482 into grafana:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants