Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a race in the scheduling limits. #3417

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fixes a race in the scheduling limits. #3417

merged 2 commits into from
Mar 2, 2021

Commits on Mar 2, 2021

  1. Fixes a race in the scheduling limits. 

    Found out the hard way that sharding might not listen correctly to context and so still run queries
after the upstream request ends. This can lead to panic when scheduling work which send on a closed channel.

I've added a safe guard to wait for all jobs to end before ending the original request but also attemped to fix the sharding downstreamer
to properly stop sending work when context is closed.

Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8e042b1 View commit details
    Browse the repository at this point in the history

  2. typo 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    12b0add View commit details
    Browse the repository at this point in the history