Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed time zone data from Go in promtail (#1361) #3242

Closed
wants to merge 1 commit into from
Closed

Embed time zone data from Go in promtail (#1361) #3242

wants to merge 1 commit into from

Conversation

splitt3r
Copy link

What this PR does / why we need it: This pr embeds the timezone data from Go in the Promtail binary. See the related issue for more info.

Which issue(s) this PR fixes:
Fixes #1361

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Links

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@splitt3r splitt3r closed this Jan 26, 2021
@splitt3r splitt3r deleted the embed-time-zone-data branch January 26, 2021 21:22
@cyriltovena
Copy link
Contributor

why did you close that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail timezone stage doesn't work well on Windows
3 participants