Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore flushed chunks during checkpointing #3195

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Ignore flushed chunks during checkpointing #3195

merged 2 commits into from
Jan 20, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 19, 2021

Will not attempt to checkpoint chunks which have already been flushed.

@owen-d owen-d requested a review from slim-bean January 19, 2021 17:09
cyriltovena
cyriltovena approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did refactored this code.

@owen-d owen-d merged commit b861757 into grafana:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @cyriltovena