Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promtail: pass registerer to gcplog #3191

Merged
merged 3 commits into from
Jan 22, 2021
Merged

promtail: pass registerer to gcplog #3191

merged 3 commits into from
Jan 22, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 19, 2021

Related to #3174, #3175; Promtail components should no longer register metrics globally with promauto anymore.

kavirajk
kavirajk approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks @rfratto

@rfratto
Copy link
Member Author

rfratto commented Jan 20, 2021

@sandeepsukhani would you like me to change anything else?

@rfratto rfratto merged commit da54d33 into grafana:master Jan 22, 2021
@rfratto rfratto deleted the gcplog-registerer branch January 22, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani left review comments

@owen-d owen-d owen-d approved these changes

@kavirajk kavirajk kavirajk approved these changes

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rfratto @sandeepsukhani @kavirajk @owen-d