Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for the documentation. #3088

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

cyriltovena
Copy link
Contributor

Found those while working on the code base.
Signed-off-by: Cyril Tovena [email protected]

@codecov-io
Copy link

Codecov Report

Merging #3088 (b0e6419) into master (e9001d8) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3088      +/-   ##
==========================================
- Coverage   62.86%   62.83%   -0.04%     
==========================================
  Files         186      186              
  Lines       15949    15949              
==========================================
- Hits        10026    10021       -5     
- Misses       4996     4999       +3     
- Partials      927      929       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 64.33% <0.00%> (-2.10%) ⬇️
pkg/logql/evaluator.go 89.87% <0.00%> (-0.36%) ⬇️

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1427,7 +1427,7 @@ memcached_client:

# The maximum number of idle connections in the memcached client pool.
# CLI flag: -<prefix>.memcached.max-idle-conns
[max_idle_conns: <int> | default = 100]
[max_idle_conns: <int> | default = 16]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any rationale why we did that? just curious!

@owen-d owen-d merged commit e83f809 into grafana:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants