-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes for the documentation. #3088
Conversation
Signed-off-by: Cyril Tovena <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
- Coverage 62.86% 62.83% -0.04%
==========================================
Files 186 186
Lines 15949 15949
==========================================
- Hits 10026 10021 -5
- Misses 4996 4999 +3
- Partials 927 929 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1427,7 +1427,7 @@ memcached_client: | |||
|
|||
# The maximum number of idle connections in the memcached client pool. | |||
# CLI flag: -<prefix>.memcached.max-idle-conns | |||
[max_idle_conns: <int> | default = 100] | |||
[max_idle_conns: <int> | default = 16] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any rationale why we did that? just curious!
Found those while working on the code base.
Signed-off-by: Cyril Tovena [email protected]