Loki: handle faults when opening boltdb files #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Nov 25, 2020
cyriltovena
reviewed
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
- Coverage 62.07% 61.92% -0.16%
==========================================
Files 182 182
Lines 14881 14890 +9
==========================================
- Hits 9237 9220 -17
- Misses 4796 4824 +28
+ Partials 848 846 -2
|
Co-authored-by: Cyril Tovena <[email protected]>
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
) * Support azure storage of azurechina,azuregerman,azureusgov Signed-off-by: Binbin Zou <[email protected]> * change pr number Signed-off-by: Binbin Zou <[email protected]> * Optimize the code Signed-off-by: Binbin Zou <[email protected]> Co-authored-by: Binbin Zou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR handled panics, however we also get faults when opening boltdb files.
This PR launches the opening of the file in a new goroutine so we can enable debug.SetPanicOnFault for just this operation and catch these faults to recover from them.